Add Scala 2.13 support #823
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zsxwing
commented
Nov 8, 2021
| def withClose[B](f: Iterator[A] => Iterator[B]): ClosableIterator[B] = new ClosableIterator[B] { | ||
| private val iter = | ||
| try { | ||
| f(iterator) |
There was a problem hiding this comment.
The change is because scala/scala-collection-compat#7 changed iterator() to iterator and it conflicts with the IteratorCloseOps.iterator field. Renaming it to fix it for 2.13.
zsxwing
commented
Nov 8, 2021
| @@ -75,10 +76,12 @@ trait DeltaLogging | |||
| } else { | |||
| Map.empty[TagDefinition, String] | |||
| } | |||
|
|
|||
| val finalTags = mutable.Map[TagDefinition, String](TAG_OP_TYPE -> opType) | |||
There was a problem hiding this comment.
Manually create the map as immutable.Map ++ got removed in Scala 2.13.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of changes are caused by the following two breaking changes in Scala.
The fix is just adding
toSeqandtoMap.See https://docs.scala-lang.org/overviews/core/collections-migration-213.html for more details.